Skip to content

[Rocm] [quantization] Fix quark ptpc moe and add test case #24649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

[Rocm] [quantization] Fix quark ptpc moe and add test case #24649

merged 1 commit into from
Sep 17, 2025

Conversation

@haoyangli-amd
Copy link
Contributor

@haoyangli-amd haoyangli-amd commented Sep 11, 2025 •
edited by github-actions bot
Loading

1.Add support for loading quark's ptpc-format moe models
2.add test case for quark ptpc

@haoyangli-amd @lihaoyang-amd
fix quark ptpc moe
0ccf455 
Co-authored-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
@mergify mergify bot added the rocm Related to AMD ROCm label Sep 11, 2025
@github-actions
Copy link

github-actions bot commented Sep 11, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@haoyangli-amd haoyangli-amd marked this pull request as ready for review September 12, 2025 07:14
@haoyangli-amd
Copy link
Contributor Author

haoyangli-amd commented Sep 12, 2025 •
edited
Loading

hi, @mgoin ，@robertgshaw2-redhat
Could you please help to review this pr?
Thank you so much.

@haoyangli-amd
Copy link
Contributor Author

haoyangli-amd commented Sep 16, 2025 •
edited
Loading

hi, good morning.
@mgoin
Could you please help to review this pr?
Thank you so much.

@gshtras gshtras added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 16, 2025
@simon-mo simon-mo merged commit ca2d192 into vllm-project:main Sep 17, 2025
58 checks passed
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@haoyangli-amd @lihaoyang-amd @FeiDaLI
[Rocm] [quantization] Fix quark ptpc moe and add test case (vllm-proj…
263fb99 
…ect#24649)

Signed-off-by: Haoyang Li <[email protected]>
Co-authored-by: Haoyang Li <[email protected]>
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
@haoyangli-amd @lihaoyang-amd @charlifu
[Rocm] [quantization] Fix quark ptpc moe and add test case (vllm-proj…
5637508 
…ect#24649)

Signed-off-by: Haoyang Li <[email protected]>
Co-authored-by: Haoyang Li <[email protected]>
Signed-off-by: charlifu <[email protected]>
tjtanaavllm pushed a commit to ROCm/vllm that referenced this pull request Sep 26, 2025
@haoyangli-amd @lihaoyang-amd @tjtanaavllm
[Rocm] [quantization] Fix quark ptpc moe and add test case (vllm-proj…
0f70d8a 
…ect#24649)

Signed-off-by: Haoyang Li <[email protected]>
Co-authored-by: Haoyang Li <[email protected]>
tjtanaavllm added a commit to ROCm/vllm that referenced this pull request Sep 26, 2025
@tjtanaavllm
[Rocm] [quantization] Fix quark ptpc moe and add test case (vllm-proj…
aa0aa32 
…ect#24649) from upstream

[Rocm] [quantization] Fix quark ptpc moe and add test case (vllm-project#24649)
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@haoyangli-amd @lihaoyang-amd @xuebwang-amd
[Rocm] [quantization] Fix quark ptpc moe and add test case (vllm-proj…
e1a6fd1 
…ect#24649)

Signed-off-by: Haoyang Li <[email protected]>
Co-authored-by: Haoyang Li <[email protected]>
Signed-off-by: xuebwang-amd <[email protected]>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
@haoyangli-amd @lihaoyang-amd @choprahetarth
[Rocm] [quantization] Fix quark ptpc moe and add test case (vllm-proj…
5f7d7a1 
…ect#24649)

Signed-off-by: Haoyang Li <[email protected]>
Co-authored-by: Haoyang Li <[email protected]>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@haoyangli-amd @lihaoyang-amd @xuebwang-amd
[Rocm] [quantization] Fix quark ptpc moe and add test case (vllm-proj…
195fe3c 
…ect#24649)

Signed-off-by: Haoyang Li <[email protected]>
Co-authored-by: Haoyang Li <[email protected]>
Signed-off-by: xuebwang-amd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gshtras gshtras gshtras approved these changes

@mgoin mgoin Awaiting requested review from mgoin

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@yewentao256 yewentao256 Awaiting requested review from yewentao256

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@haoyangli-amd @gshtras @simon-mo